[inconsistency] HookResult defined in nothooks, not notcore #8

New Issue

joe · 2026-04-01T01:22:39-05:00

joe commented

2026-04-01 01:22:39 -05:00

Audit finding (low): HookPhase and HookSpec are shared types in notcore (correct), but HookResult is defined in nothooks even though it is part of the same conceptual group.

notstrap works around this by using StepStatus from notcore instead of HookResult directly.

Consider: Either move HookResult to notcore for consistency, or document clearly why result types are intentionally crate-local (e.g. to avoid notcore depending on execution semantics).

**Audit finding (low):** `HookPhase` and `HookSpec` are shared types in `notcore` (correct), but `HookResult` is defined in `nothooks` even though it is part of the same conceptual group. `notstrap` works around this by using `StepStatus` from `notcore` instead of `HookResult` directly. **Consider:** Either move `HookResult` to `notcore` for consistency, or document clearly why result types are intentionally crate-local (e.g. to avoid notcore depending on execution semantics).

joe referenced this issue from a commit

2026-04-15 20:32:50 -05:00

fix(notfiles): save state on partial link failure; skip re-copy of unchanged files

joe closed this issue

2026-04-16 07:53:42 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: joe/notfiles#8