[P0] Post-merge audit: check for convention conflicts after nothooks merge #2

New Issue

joe · 2026-03-31T19:58:35-05:00

joe commented

2026-03-31 19:58:35 -05:00

Council finding: the feature/nothooks branch was merged into feature/workspace-restructure and both were merged to main. Risk of conflicting conventions introduced during the merge.

What to check:

Naming consistency across crates (types, config keys, error variants)
Config file locations (.nothooks-state.toml, notfiles.toml, notstrap.toml — do they conflict?)
Hook script assumptions (Nu script paths, phase names)
Any duplicate or inconsistent implementations of shared concerns

Source: devloop council analysis 2026-03-31

Council finding: the `feature/nothooks` branch was merged into `feature/workspace-restructure` and both were merged to main. Risk of conflicting conventions introduced during the merge. **What to check:** - Naming consistency across crates (types, config keys, error variants) - Config file locations (`.nothooks-state.toml`, `notfiles.toml`, `notstrap.toml` — do they conflict?) - Hook script assumptions (Nu script paths, phase names) - Any duplicate or inconsistent implementations of shared concerns Source: devloop council analysis 2026-03-31

joe referenced this issue from a commit

2026-04-01 01:22:50 -05:00

fix(notcore): add .nothooks-state.toml to default_ignore and starter_toml

joe closed this issue

2026-04-01 01:22:50 -05:00

joe referenced this issue from a commit

2026-04-04 00:14:33 -05:00

fix: address security findings from devkit-review (#1–#7)

joe referenced this issue from a commit

2026-06-06 08:49:18 -05:00

fix(preflight): make preflight.nu script executable (#2)

Sign in to join this conversation.