security: audit Command call sites; confirm no argument injection

Closes #18

All six Command::new call sites audited:
- bitwarden.rs (sh -c): shell string is a hardcoded literal; no user data.
- bitwarden.rs (bw unlock): all args hardcoded.
- bitwarden.rs (bw get): item_name and session passed as discrete .args() elements; no shell.
- nothooks/runner.rs (nu/sh/etc): interp and script path passed as discrete args; no shell.
- notstrap/repo.rs (git clone): url and dest passed as discrete .arg() calls; no shell.
- notfiles/tests/integration.rs: test harness with hardcoded args only.

Added SAFETY comments on the three sites that handle user-controlled config values.
This commit is contained in:
Joseph O'Brien
2026-04-11 23:52:40 -04:00
parent 822abd9c88
commit 19e74b4a1b
3 changed files with 10 additions and 0 deletions

View File

@@ -6,6 +6,9 @@ pub fn clone_if_missing(url: &str, dest: &Path) -> Result<bool> {
if dest.exists() {
return Ok(false);
}
// SAFETY: `url` comes from the notstrap.toml config and `dest` is a `Path` derived from
// the resolved dotfiles directory. Both are passed as discrete `.arg()` calls with no
// shell involved, so argument injection is not possible.
let status = Command::new("git")
.arg("clone")
.arg(url)